I think the patch is fine, based on the comments in the bug.
My only concern is whether this could cause cross-platform problems or environment-dependent problems for 2.5 with no more betas before final release. But, given that Mark says signing from the gui is broken on unix without it, perhaps it's better off merged
[tweak] There are some merge conflicts and it needs a news entry. Could you handle them, Mark?
I think the patch is fine, based on the comments in the bug.
My only concern is whether this could cause cross-platform problems or environment- dependent problems for 2.5 with no more betas before final release. But, given that Mark says signing from the gui is broken on unix without it, perhaps it's better off merged
[tweak] There are some merge conflicts and it needs a news entry. Could you handle them, Mark?