Merge lp://staging/~markgrandi/bzr/gpg_devttynotfound_fix into lp://staging/bzr/2.5
Proposed by
Mark Grandi
Status: | Merged |
---|---|
Approved by: | Martin Packman |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6484 |
Proposed branch: | lp://staging/~markgrandi/bzr/gpg_devttynotfound_fix |
Merge into: | lp://staging/bzr/2.5 |
Diff against target: |
56 lines (+7/-4) 3 files modified
bzrlib/gpg.py (+1/-1) bzrlib/tests/test_gpg.py (+3/-3) doc/en/release-notes/bzr-2.5.txt (+3/-0) |
To merge this branch: | bzr merge lp://staging/~markgrandi/bzr/gpg_devttynotfound_fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Needs Fixing | ||
Jelmer Vernooij (community) | Approve | ||
Martin Pool | Needs Fixing | ||
Review via email: mp+93144@code.staging.launchpad.net |
Commit message
Pass --no-tty to gpg when running it from a subprocess in bzr
Description of the change
fixed problem with gpg complaining about not having a tty when using this with bazaar explorer on ubuntu
To post a comment you must log in.
I think the patch is fine, based on the comments in the bug.
My only concern is whether this could cause cross-platform problems or environment- dependent problems for 2.5 with no more betas before final release. But, given that Mark says signing from the gui is broken on unix without it, perhaps it's better off merged
[tweak] There are some merge conflicts and it needs a news entry. Could you handle them, Mark?