Code review comment for lp://staging/~mark-mims/charmrunner/record-without-environment

lgtm

On Sun, Jul 1, 2012 at 11:52 PM, Mark Mims <email address hidden> wrote:

> Mark Mims has proposed merging
> lp:~mark-mims/charmrunner/record-without-environment into lp:charmrunner.
>
> Requested reviews:
> Juju-Jitsu Hackers (juju-jitsu)
>
> For more details, see:
>
> https://code.launchpad.net/~mark-mims/charmrunner/record-without-environment/+merge/112960
>
> recorder should exclude environment node from the zk dump.
> --
>
> https://code.launchpad.net/~mark-mims/charmrunner/record-without-environment/+merge/112960
> Your team Juju-Jitsu Hackers is requested to review the proposed merge of
> lp:~mark-mims/charmrunner/record-without-environment into lp:charmrunner.
>
> === modified file 'charmrunner/recorder.py'
> --- charmrunner/recorder.py 2012-04-15 20:34:38 +0000
> +++ charmrunner/recorder.py 2012-07-02 03:51:20 +0000
> @@ -42,6 +42,8 @@
> for child in (yield c.get_children(p)):
> if child == 'zookeeper': # skip the md node
> continue
> + if child == 'environment': # exclude credentials
> + continue
> child_path = "/" + ("%s/%s" % (p, child)).strip("/")
> yield _dump(c, child_path)
> contents, stat = yield c.get(child_path)
>
>
>