Merge lp://staging/~mark-mims/charmrunner/record-without-environment into lp://staging/charmrunner

Proposed by Mark Mims
Status: Merged
Merged at revision: 32
Proposed branch: lp://staging/~mark-mims/charmrunner/record-without-environment
Merge into: lp://staging/charmrunner
Diff against target: 12 lines (+2/-0)
1 file modified
charmrunner/recorder.py (+2/-0)
To merge this branch: bzr merge lp://staging/~mark-mims/charmrunner/record-without-environment
Reviewer Review Type Date Requested Status
Juju-Jitsu Hackers Pending
Review via email: mp+112960@code.staging.launchpad.net

Description of the change

recorder should exclude environment node from the zk dump.

To post a comment you must log in.
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

lgtm

On Sun, Jul 1, 2012 at 11:52 PM, Mark Mims <email address hidden> wrote:

> Mark Mims has proposed merging
> lp:~mark-mims/charmrunner/record-without-environment into lp:charmrunner.
>
> Requested reviews:
> Juju-Jitsu Hackers (juju-jitsu)
>
> For more details, see:
>
> https://code.launchpad.net/~mark-mims/charmrunner/record-without-environment/+merge/112960
>
> recorder should exclude environment node from the zk dump.
> --
>
> https://code.launchpad.net/~mark-mims/charmrunner/record-without-environment/+merge/112960
> Your team Juju-Jitsu Hackers is requested to review the proposed merge of
> lp:~mark-mims/charmrunner/record-without-environment into lp:charmrunner.
>
> === modified file 'charmrunner/recorder.py'
> --- charmrunner/recorder.py 2012-04-15 20:34:38 +0000
> +++ charmrunner/recorder.py 2012-07-02 03:51:20 +0000
> @@ -42,6 +42,8 @@
> for child in (yield c.get_children(p)):
> if child == 'zookeeper': # skip the md node
> continue
> + if child == 'environment': # exclude credentials
> + continue
> child_path = "/" + ("%s/%s" % (p, child)).strip("/")
> yield _dump(c, child_path)
> contents, stat = yield c.get(child_path)
>
>
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: