Code review comment for lp://staging/~lukas-kde/qtmir/wheelEvent

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> Could you please move "getMirButtonsFromQt(qtEvent->buttons())" into a
> separate variable like it's being done for timestamp and modifiers?
>
> The mir::events::make_event() call is already messy from having such a large
> number of parameters. Using those helper variables improve readability and I
> think won't impact performance as I bet they will be optimized away by the
> compiler.

Done

« Back to merge proposal