Code review comment for lp://staging/~liuyq0307/linaro-android-build-tools/run-custom

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Sorry that this takes long to review. One of the reason is that there're lot of "spurious" changes, not directly related to the implementation of requested feature. E.g. line 16 (and lot of others), where whitespace change made. I agree that keeping consistent and correct style is important matter, and those fixes look good, but they should be done separately from feature development (at the very least - in separate commits).

There's nothing can be done about that now, but please separate such changes in the future. Thanks.

« Back to merge proposal