Merge lp://staging/~liuyq0307/linaro-android-build-tools/run-custom into lp://staging/linaro-android-build-tools
Proposed by
Yongqin Liu
Status: | Superseded |
---|---|
Proposed branch: | lp://staging/~liuyq0307/linaro-android-build-tools/run-custom |
Merge into: | lp://staging/linaro-android-build-tools |
Diff against target: |
161 lines (+61/-21) 1 file modified
build-scripts/post-build-lava.py (+61/-21) |
To merge this branch: | bzr merge lp://staging/~liuyq0307/linaro-android-build-tools/run-custom |
Related bugs: | |
Related blueprints: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Sokolovsky | Disapprove | ||
Linaro Validation Team | Pending | ||
Review via email: mp+98825@code.staging.launchpad.net |
This proposal has been superseded by a proposal from 2012-04-11.
Description of the change
add support to generate run-custom actions for lava-job
To post a comment you must log in.
Sorry that this takes long to review. One of the reason is that there're lot of "spurious" changes, not directly related to the implementation of requested feature. E.g. line 16 (and lot of others), where whitespace change made. I agree that keeping consistent and correct style is important matter, and those fixes look good, but they should be done separately from feature development (at the very least - in separate commits).
There's nothing can be done about that now, but please separate such changes in the future. Thanks.