Merge lp://staging/~liuyq0307/linaro-android-build-tools/run-custom into lp://staging/linaro-android-build-tools
Proposed by
Yongqin Liu
Status: | Merged |
---|---|
Approved by: | Paul Sokolovsky |
Approved revision: | 431 |
Merged at revision: | 446 |
Proposed branch: | lp://staging/~liuyq0307/linaro-android-build-tools/run-custom |
Merge into: | lp://staging/linaro-android-build-tools |
Diff against target: |
161 lines (+61/-21) 1 file modified
build-scripts/post-build-lava.py (+61/-21) |
To merge this branch: | bzr merge lp://staging/~liuyq0307/linaro-android-build-tools/run-custom |
Related bugs: | |
Related blueprints: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Sokolovsky | Approve | ||
Spring Zhang (community) | Approve | ||
Review via email: mp+101503@code.staging.launchpad.net |
This proposal supersedes a proposal from 2012-03-22.
Description of the change
add support for generating lava-job actions of running custom android command
the document about how to use is updated in https:/
To post a comment you must log in.
Sorry that this takes long to review. One of the reason is that there're lot of "spurious" changes, not directly related to the implementation of requested feature. E.g. line 16 (and lot of others), where whitespace change made. I agree that keeping consistent and correct style is important matter, and those fixes look good, but they should be done separately from feature development (at the very least - in separate commits).
There's nothing can be done about that now, but please separate such changes in the future. Thanks.