Code review comment for lp://staging/~kissiel/checkbox/extend-resume

Revision history for this message
Pierre Equoy (pieq) wrote :

Two comments:

1. Could it be possible to add the name of the job in the dialogbox?

That is, instead of:

-----------------------------
What to do with the last job?

[Pass]
[Skip]
[Fail]
-----------------------------

Having:

-----------------------------
What to do with the last job?
(“suspend/suspend_advanced”)

[Pass]
[Skip]
[Fail]
-----------------------------

Either display the job summary if avaible or else the job id.

2. When you select something from the new dialogbox, the screen goes back to the resume screen for a while before continuing, and the "Delete sessions" button seems clickable (at least I clicked it, but I don't think it actually deleted the sessions). It would be better to display some sort of "Loading" thing to let the user know something is happening in the background.

review: Needs Fixing

« Back to merge proposal