Merge lp://staging/~kissiel/checkbox/extend-resume into lp://staging/checkbox
Proposed by
Maciej Kisielewski
| Status: | Merged |
|---|---|
| Approved by: | Sylvain Pineau |
| Approved revision: | 4424 |
| Merged at revision: | 4420 |
| Proposed branch: | lp://staging/~kissiel/checkbox/extend-resume |
| Merge into: | lp://staging/checkbox |
| Diff against target: |
268 lines (+126/-27) 6 files modified
checkbox-touch/checkbox-touch.qml (+9/-5) checkbox-touch/components/CheckboxTouchApplication.qml (+2/-2) checkbox-touch/components/ResumeSessionPage.qml (+30/-2) checkbox-touch/py/checkbox_touch.py (+6/-2) checkbox-touch/tests/autopilot/checkbox_touch/test_checkbox_touch.py (+79/-15) plainbox/plainbox/impl/session/assistant.py (+0/-1) |
| To merge this branch: | bzr merge lp://staging/~kissiel/checkbox/extend-resume |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sylvain Pineau (community) | Approve | ||
| Pierre Equoy | Approve | ||
|
Review via email:
|
|||
Description of the change
This MR brings an option to pass/skip/fail last run test on the resume screen
It fixes https:/
To test it, start a session using c-b-c, interrupt it, and play around with different resume options.
To post a comment you must log in.
Revision history for this message
| Maciej Kisielewski (kissiel) wrote | # |
Revision history for this message
| Sylvain Pineau (sylvain-pineau) wrote | # |
Download full text (5.4 KiB)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Two comments:
1. Could it be possible to add the name of the job in the dialogbox?
That is, instead of:
-------
What to do with the last job?
[Pass]
[Skip]
[Fail]
-------
Having:
-------
What to do with the last job?
(“suspend/
[Pass]
[Skip]
[Fail]
-------
Either display the job summary if avaible or else the job id.
2. When you select something from the new dialogbox, the screen goes back to the resume screen for a while before continuing, and the "Delete sessions" button seems clickable (at least I clicked it, but I don't think it actually deleted the sessions). It would be better to display some sort of "Loading" thing to let the user know something is happening in the background.