Code review comment for lp://staging/~kentb/ubuntu/raring/ledmon/dell-pcie-ssd-fix_lp1174386

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, some comments:
- could you use a diff in debian/patches rather than doing inline changes?
- could you add references to the upstream commit (seems to be http://ledmon.git.sourceforge.net/git/gitweb.cgi?p=ledmon/ledmon;a=commitdiff;h=d6b7c55869fa7a5224844407ef2d5aab785c4db8)?
- could you forward that bug/patch to debian, we are in sync with them and it would be good if that kept being the case

review: Needs Fixing

« Back to merge proposal