Ubuntu
ledmon package

Merge lp://staging/~kentb/ubuntu/raring/ledmon/dell-pcie-ssd-fix_lp1174386 into lp://staging/ubuntu/raring/ledmon

  1. Raring (13.04)
  2. dell-pcie-ssd-fix_lp1174386
  3. Merge into raring
Proposed by Kent Baxley
Status: Merged
Merge reported by: Stéphane Graber
Merged at revision: not available
Proposed branch: lp://staging/~kentb/ubuntu/raring/ledmon/dell-pcie-ssd-fix_lp1174386
Merge into: lp://staging/ubuntu/raring/ledmon
Diff against target: 937 lines (+879/-2)
6 files modified
.pc/applied-patches (+1/-0)
.pc/fix-dell-devices.patch/src/ledmon.c (+833/-0)
debian/changelog (+6/-0)
debian/patches/fix-dell-devices.patch (+31/-0)
debian/patches/series (+1/-0)
src/ledmon.c (+7/-2)
To merge this branch: bzr merge lp://staging/~kentb/ubuntu/raring/ledmon/dell-pcie-ssd-fix_lp1174386
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Ubuntu branches Pending
Review via email: mp+161696@code.staging.launchpad.net

Description of the change

Adds in a small upstream fix for PCIe SSD devices on Dell Servers.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, some comments:
- could you use a diff in debian/patches rather than doing inline changes?
- could you add references to the upstream commit (seems to be http://ledmon.git.sourceforge.net/git/gitweb.cgi?p=ledmon/ledmon;a=commitdiff;h=d6b7c55869fa7a5224844407ef2d5aab785c4db8)?
- could you forward that bug/patch to debian, we are in sync with them and it would be good if that kept being the case

review: Needs Fixing
lp://staging/~kentb/ubuntu/raring/ledmon/dell-pcie-ssd-fix_lp1174386 updated
7. By Kent Baxley

add patches directory with actual diff

Revision history for this message
Kent Baxley (kentb) wrote :

Hi Sebastien,

Thanks for the feedback. I've added the upstream commit reference to the summary and have added the patch info in the debian/ directory. This is the first time I've added a patch like this, so, please let me know if I did it correctly :)

I'll also get a bug opened in debian and link it up here.

Thanks!

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I've uploaded that to both raring and saucy

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: