MAAS

Merge lp://staging/~julian-edwards/maas/releasenotes-1.6 into lp://staging/~maas-committers/maas/trunk

releasenotes-1.6
Merge into trunk

Proposed by Julian Edwards on 2014-07-08

Status:	Superseded
Proposed branch:	lp://staging/~julian-edwards/maas/releasenotes-1.6
Merge into:	lp://staging/~maas-committers/maas/trunk
Diff against target:	259 lines (+165/-2) (has conflicts) 5 files modified docs/changelog.rst (+125/-0) src/maasserver/rpc/tests/test_regionservice.py (+15/-0) src/provisioningserver/drivers/osystem/ubuntu.py (+1/-2) src/provisioningserver/import_images/boot_resources.py (+15/-0) src/provisioningserver/upgrade_cluster.py (+9/-0) Text conflict in src/maasserver/rpc/tests/test_regionservice.py Text conflict in src/provisioningserver/import_images/boot_resources.py Text conflict in src/provisioningserver/upgrade_cluster.py
To merge this branch:	bzr merge lp://staging/~julian-edwards/maas/releasenotes-1.6
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Jeroen T. Vermeulen (community)		2014-07-08	Approve on 2014-07-10
Review via email: mp+225923@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-08-12.

Revision history for this message

Raphaël Badin (rvb) on 2014-07-08:

Revision history for this message

Jeroen T. Vermeulen (jtv) wrote on 2014-07-10:

The special notice is useful, but not very clear I think, from the standpoint of someone who doesn't yet know what it's about. Maybe split this up into sentences conveying separate points of information? 1. Cluster interfaces now have "static IP ranges." 2. These are needed in order to give stable IP addresses to nodes. 3. You need to edit them.

Revision history for this message

Jeroen T. Vermeulen (jtv) wrote on 2014-07-10:

The IP Addresses Overhaul section has a complete afterthought in parentheses. I would recommend making that a separate sentence. It can still be in parentheses, as long as the previous sentence clearly ends before the parenthetical text. Otherwise you're asking the reader to keep the whole thing in mind, just in case the original sentence resumes after the parenthetical remark.

Revision history for this message

Jeroen T. Vermeulen (jtv) wrote on 2014-07-10:

This sentence looks like it's sort of the wrong way around:

«Additionally, only addresses in the new static range will receive DNS entries for cluster interfaces that provide DNS management.»

The text looks as if the DNS entries are “for” cluster interfaces when really it's more as if they're received “from” cluster interfaces.

Suggestion:

«The DNS server built into MAAS will only provide IP addresses in this static range.»

Revision history for this message

Jeroen T. Vermeulen (jtv) wrote on 2014-07-10:

The heading "IP Addresses Overhaul" heading is capitalised differently from the other ones.

Phrasing is a bit roundabout throughout the second half of this paragraph:

«DNS entries
  In 1.5 DNS entries for nodes were a CNAME record. As of 1.6, they are now
  all "A" records, and the pre-generation of the entire range defined in the
  zone is now not done (to speed up the job that writes the zone). This
  means that depending on DNS entries for unallocated nodes is no longer
  possible.»

I suspect that the need to explain pre-generation first is what makes this hard to formulate. Forces you to go through things in an awkward order. Maybe the reader doesn't really need to know about pre-generation as such? Because in that case, I think you could cover the subject with:

1. Unallocated nodes no longer have DNS entries.
2. Host names are now mapped as A records.
3. Therefore, reverse lookup now works!
4. DNS management is faster.

Instead of this:

«Existing nodes still require editing to change the installer in use, however.»

I would say something like:

«By default, existing nodes will keep using the installer they used before.»

—assuming that's what you mean, of course.

Thanks for taking care of this chore!

review: Approve

Revision history for this message

Julian Edwards (julian-edwards) wrote on 2014-07-11:

> The special notice is useful, but not very clear I think, from the standpoint of someone who doesn't yet know what it's about. Maybe split this up into sentences conveying separate points of information? 1. Cluster interfaces now have "static IP ranges." 2. These are needed in order to give stable IP addresses to nodes. 3. You need to edit them.

I've reworded it along your lines, thanks.

> The IP Addresses Overhaul section has a complete afterthought in parentheses. I would recommend making that a separate sentence. It can still be in parentheses, as long as the previous sentence clearly ends before the parenthetical text. Otherwise you're asking the reader to keep the whole thing in mind, just in case the original sentence resumes after the parenthetical remark.

Done!

> Suggestion:
> «The DNS server built into MAAS will only provide IP addresses in this static range.»

I've reworded it as this is not quite true any more, thanks.

> The heading "IP Addresses Overhaul" heading is capitalised differently from the other ones.

Oops, fixed.

> I suspect that the need to explain pre-generation first is what makes this hard to formulate. Forces you to go through things in an awkward order. Maybe the reader doesn't really need to know about pre-generation as such? Because in that case, I think you could cover the subject with:
>
> 1. Unallocated nodes no longer have DNS entries.
> 2. Host names are now mapped as A records.
> 3. Therefore, reverse lookup now works!
> 4. DNS management is faster.

Done.

> I would say something like:
>
> «By default, existing nodes will keep using the installer they used before.»
>
> —assuming that's what you mean, of course.

Yes, and done.

> Thanks for taking care of this chore!

It keeps me out of trouble.

And thanks for the reviewing chore!

Revision history for this message

Raphaël Badin (rvb) wrote on 2014-08-11:

Might be worth mentioning that the cluster<->region communications now requires arbitrary high-numbered port connections. See https://bugs.launchpad.net/maas/+bug/1352923 for details.

Revision history for this message

Raphaël Badin (rvb) wrote on 2014-08-11:

> Might be worth mentioning that the cluster<->region communications now
> requires arbitrary high-numbered port connections. See
> https://bugs.launchpad.net/maas/+bug/1352923 for details.

What I meant is that, when we fix this, we will still require a range of ports to be open for cluster<->region communication (I assume we will fix the bug linked above this way); this should probably be mentioned in the release notes.

Revision history for this message

Julian Edwards (julian-edwards) wrote on 2014-08-11:

On Monday 11 Aug 2014 13:06:43 you wrote:
> > Might be worth mentioning that the cluster<->region communications now
> > requires arbitrary high-numbered port connections. See
> > https://bugs.launchpad.net/maas/+bug/1352923 for details.
>
> What I meant is that, when we fix this, we will still require a range of
> ports to be open for cluster<->region communication (I assume we will fix
> the bug linked above this way); this should probably be mentioned in the
> release notes.

Urgh, right. Gavin, do we have any idea of what a rough range of the ports
will be? I can't just say "any old high-numered ports", people will rightly
laugh.