Code review comment for lp://staging/~julian-edwards/launchpad/api-commercial-ppas-bug-597211

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Nice branch. Just a few remarks as per IRC:

 * "Lets" in the doctest is a typo for "Let's."

 * Starting doctest paragraphs with "Let's" usually indicates you're passing off setup as documentation. You can just say "we have a" or "foo is a."

 * Use IStore instead of IStoreSelector... it saves typing.

That's it. Approving.

review: Approve

« Back to merge proposal