Merge lp://staging/~julian-edwards/launchpad/api-commercial-ppas-bug-597211 into lp://staging/launchpad/db-devel
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 9512 | ||||
| Proposed branch: | lp://staging/~julian-edwards/launchpad/api-commercial-ppas-bug-597211 | ||||
| Merge into: | lp://staging/launchpad/db-devel | ||||
| Diff against target: |
193 lines (+122/-0) 7 files modified
lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+2/-0) lib/lp/registry/interfaces/distribution.py (+12/-0) lib/lp/registry/model/distribution.py (+6/-0) lib/lp/soyuz/doc/archive-commercial.txt (+56/-0) lib/lp/soyuz/interfaces/archive.py (+8/-0) lib/lp/soyuz/model/archive.py (+10/-0) lib/lp/soyuz/stories/webservice/xx-archive-commercial.txt (+28/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~julian-edwards/launchpad/api-commercial-ppas-bug-597211 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jeroen T. Vermeulen (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
= Summary =
Add IDistribution.
== Implementation details ==
Trivial change!
== Tests ==
bin/test -cvvt archive-
== Demo and Q/A ==
Will set up a commercial PPA on staging and query it with the webservice.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/canonical
lib/lp/
== Pylint notices ==
<deletetia> - madness ensues with lint checking on interfaces with exports
Nice branch. Just a few remarks as per IRC:
* "Lets" in the doctest is a typo for "Let's."
* Starting doctest paragraphs with "Let's" usually indicates you're passing off setup as documentation. You can just say "we have a" or "foo is a."
* Use IStore instead of IStoreSelector... it saves typing.
That's it. Approving.