Code review comment for lp://staging/~john-pankov/dockmanager/quicklists

Revision history for this message
Michal Hruby (mhr3) wrote :

1) the DesktopFile property can be empty string if the window can't be matched, you don't handle that
2) you should cache the desktop files you already loaded at some point, we don't need extra i/o on every window close/open cycle

review: Needs Fixing

« Back to merge proposal