Merge lp://staging/~john-pankov/dockmanager/quicklists into lp://staging/dockmanager

Proposed by Eugene Pankov
Status: Merged
Merged at revision: 95
Proposed branch: lp://staging/~john-pankov/dockmanager/quicklists
Merge into: lp://staging/dockmanager
Diff against target: 142 lines (+111/-0)
4 files modified
metadata/Makefile.am (+1/-0)
metadata/quicklists.py.info (+4/-0)
scripts/Makefile.am (+1/-0)
scripts/quicklists.py (+105/-0)
To merge this branch: bzr merge lp://staging/~john-pankov/dockmanager/quicklists
Reviewer Review Type Date Requested Status
Eugene Pankov (community) Approve
Rico Tzschichholz Approve
Michal Hruby (community) Approve
Review via email: mp+63570@code.staging.launchpad.net

Description of the change

Added support for the Unity Quicklists

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Since this is Ubuntu-specific, I think it'd be much better to read just the desktop cache file and also install a file monitor on it, and if it doesn't exist then assume this ain't Ubuntu and there are no Unity-specific desktop files.

Revision history for this message
Eugene Pankov (john-pankov) wrote :

AFAIK desktop*.cache doesn't contain X-Ayatana-Desktop-Shortcuts entries.
Also not sure if the file monitor is needed - we'll get item_path_found() if user launches newly installed app.
Please let me know your thoughts on this.

Revision history for this message
Michal Hruby (mhr3) wrote :

You're right, my bad... Still I don't like the crawling of all the desktop files, ultimately you do get the path to desktop file in the item_path_found() method, so it'd be much better to just load it there.

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Interesting, but indeed you should use the desktop-file-path over dbus and scan it for quicklists. Scanning the whole applications-folder everytime isnt nice.

review: Needs Fixing
96. By Eugene Pankov

Enhanced quicklists backend

Revision history for this message
Eugene Pankov (john-pankov) wrote :

Fixed

review: Needs Resubmitting
Revision history for this message
Michal Hruby (mhr3) wrote :

1) the DesktopFile property can be empty string if the window can't be matched, you don't handle that
2) you should cache the desktop files you already loaded at some point, we don't need extra i/o on every window close/open cycle

review: Needs Fixing
97. By Eugene Pankov

Added desktop file caching to quicklists

Revision history for this message
Eugene Pankov (john-pankov) wrote :

Fixed both points

review: Needs Resubmitting
Revision history for this message
Michal Hruby (mhr3) wrote :

One last thing, please use glib/gio to launch the desktop files (instead of Popen), that will enable you to get rid of the remove_params function.

review: Needs Fixing
98. By Eugene Pankov

Replaced subprocess with gio in quicklists helper

Revision history for this message
Eugene Pankov (john-pankov) wrote :

Fixed

Revision history for this message
Michal Hruby (mhr3) wrote :

Looks good to me...

review: Approve
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Would be nice if available translations of the QuickList entries could be taken into account. This means using Name[LOCALE]=... with a fallback to Name=...

99. By Eugene Pankov

Added localization support to quicklists

Revision history for this message
Eugene Pankov (john-pankov) wrote :

Done

Revision history for this message
Rico Tzschichholz (ricotz) :
review: Approve
Revision history for this message
Eugene Pankov (john-pankov) wrote :

...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: