Code review comment for lp://staging/~joetalbott/uci-engine/add_ready_checkbox

Revision history for this message
Celso Providelo (cprov) wrote :

Joe,

To be clear, "Silo creating" + "In Progress" is the right step+status for this scenario.

Just a followup about the regarding the possible use of QUEUED, since it's value is greater than all CITRAIN-related constants, the status section will render full-checked, as it the ticket has completed itself successfully.

We can't mix CITRAIN & UCI-E step, because the way they were created, OTOH we can re-process completed ci-train tickets with UCI-E components if we need to (dropping the citrain-overlay and moving the ticket to QUEUED).

« Back to merge proposal