Ubuntu CI Engine

Merge lp://staging/~joetalbott/uci-engine/add_ready_checkbox into lp://staging/uci-engine

  1. add_ready_checkbox
  2. Merge into trunk
Proposed by Joe Talbott
Status: Superseded
Proposed branch: lp://staging/~joetalbott/uci-engine/add_ready_checkbox
Merge into: lp://staging/uci-engine
Diff against target: 88 lines (+46/-0)
2 files modified
tests/test_webui.py (+29/-0)
webui/tickets/static/tickets/webuiforms.js (+17/-0)
To merge this branch: bzr merge lp://staging/~joetalbott/uci-engine/add_ready_checkbox
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Para Siva (community) Approve
Celso Providelo (community) Needs Fixing
Review via email: mp+243878@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-12-19.

Commit message

Add "Ready to assign" checkbox to ticket create form.

* Sets current_workflow_step to 'Queued' when checked (upon form submission)

Description of the change

Add "Ready to assign" checkbox to ticket create form.

* Sets current_workflow_step to 'Queued' when checked (upon form submission)

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Joe,

Thanks for working on this.

Apart for the inline comment, can you extend the webui ticket creation test cover this new field ?

review: Needs Fixing
Revision history for this message
Celso Providelo (cprov) wrote :

Joe,

To be clear, "Silo creating" + "In Progress" is the right step+status for this scenario.

Just a followup about the regarding the possible use of QUEUED, since it's value is greater than all CITRAIN-related constants, the status section will render full-checked, as it the ticket has completed itself successfully.

We can't mix CITRAIN & UCI-E step, because the way they were created, OTOH we can re-process completed ci-train tickets with UCI-E components if we need to (dropping the citrain-overlay and moving the ticket to QUEUED).

Revision history for this message
Para Siva (psivaa) wrote :

+1, only an inline nitpick.

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

Sets the silo assigning spinner when checked. Looks good.

review: Approve
Revision history for this message
Ubuntu CI Bot (uci-bot) wrote :

Attempt to merge into lp:uci-engine failed due to conflicts:

text conflict in tests/test_webui.py

lp://staging/~joetalbott/uci-engine/add_ready_checkbox updated
910. By Joe Talbott <email address hidden>

merge with trunk and fix conflict in tests/test_webui.py

Unmerged revisions

910. By Joe Talbott <email address hidden>

merge with trunk and fix conflict in tests/test_webui.py

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches