Code review comment for lp://staging/~jkakar/storm/better-timeout-messages

Revision history for this message
Jamu Kakar (jkakar) wrote :

Michael:

I wondered about the changes to TimeoutError.__init__ breaking
client code, too. The sense I have is that it would be fairly odd
for client code to use what is basically an internal Storm exception
type. I suspect that any non-Storm code using it is doing something
funky that we don't need to worry about supporting.

« Back to merge proposal