Merge lp://staging/~jkakar/storm/better-timeout-messages into lp://staging/storm
Proposed by
Jamu Kakar
Status: | Merged |
---|---|
Approved by: | Jamu Kakar |
Approved revision: | 371 |
Merged at revision: | 370 |
Proposed branch: | lp://staging/~jkakar/storm/better-timeout-messages |
Merge into: | lp://staging/storm |
Diff against target: |
135 lines (+42/-10) 5 files modified
storm/databases/postgres.py (+2/-1) storm/exceptions.py (+4/-2) storm/tracer.py (+20/-2) tests/databases/postgres.py (+3/-2) tests/tracer.py (+13/-3) |
To merge this branch: | bzr merge lp://staging/~jkakar/storm/better-timeout-messages |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Hudson-Doyle | Approve | ||
Robert Collins (community) | Approve | ||
Storm Developers | Pending | ||
Review via email: mp+32687@code.staging.launchpad.net |
Description of the change
This branch introduces the following changes:
- Adds a description when TimeoutError's are raised.
- Improves TimeoutTracer docstrings.
To post a comment you must log in.
Looks great to me. I don't know the code well enough to spot any flaws :)
The TimeoutTracer docstring could be a little clearer in the first sentence.
Perhaps
"""Provide a timeout facility for connections to prevent rogue operations.
...
"""