Code review comment for lp://staging/~jkakar/storm/better-timeout-messages

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Hi, this looks fine and a clear improvement.

Is there any chance that changing the signature of TimeoutError.__init__ will break client code? It does seem unlikely, but I thought it was worth asking :-)

review: Approve

« Back to merge proposal