Code review comment for lp://staging/~jelmer/lptools/standard-login

Revision history for this message
Martin Pool (mbp) wrote :

Hooray for removing duplicated code.

It might be worth checking there is a specific version check against lplib so that people will get a clean message if it's out of date.

I think the api changes in lplib will make it a bit hard to support multiple versions and I don't think it's a priority compared to just getting the code moving on the current version.

review: Approve

« Back to merge proposal