Merge lp://staging/~jelmer/lptools/standard-login into lp://staging/lptools
Proposed by
Jelmer Vernooij
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Martin Pool | ||||||||
| Approved revision: | 25 | ||||||||
| Merged at revision: | 26 | ||||||||
| Proposed branch: | lp://staging/~jelmer/lptools/standard-login | ||||||||
| Merge into: | lp://staging/lptools | ||||||||
| Diff against target: |
71 lines (+8/-45) 1 file modified
lptools/config.py (+8/-45) |
||||||||
| To merge this branch: | bzr merge lp://staging/~jelmer/lptools/standard-login | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Pool | Approve | ||
|
Review via email:
|
|||
Description of the change
Use the standard Launchpad.
This means relying on a newer version of launchpadlib, which will make backporting of lptools harder. Is that a problem?
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hooray for removing duplicated code.
It might be worth checking there is a specific version check against lplib so that people will get a clean message if it's out of date.
I think the api changes in lplib will make it a bit hard to support multiple versions and I don't think it's a priority compared to just getting the code moving on the current version.