Code review comment for lp://staging/~james-w/tarmac/exit-status

Revision history for this message
Jonathan Lange (jml) wrote :

+ if len(filter(lambda x: x is False, statuses)) > 0:

I don't know what's supposed to be in 'statuses', but this can definitely be simplified. If it's a sequence of booleans, then this is equivalent:

+ if False in statuses:

If it's a sequence of things which are to be interpreted as booleans, then this is equivalent:

+ if not all(statuses):

Other than that, it's all good. I'll update the MP and land it.

Oh, some test coverage would be nice.

jml

review: Approve

« Back to merge proposal