Merge lp://staging/~james-w/tarmac/exit-status into lp://staging/~ubuntuone-hackers/tarmac/trunk
Proposed by
James Westby
| Status: | Merged |
|---|---|
| Approved by: | Jonathan Lange |
| Approved revision: | 420 |
| Merged at revision: | 421 |
| Proposed branch: | lp://staging/~james-w/tarmac/exit-status |
| Merge into: | lp://staging/~ubuntuone-hackers/tarmac/trunk |
| Prerequisite: | lp://staging/~james-w/tarmac/break-up-do-merges |
| Diff against target: |
54 lines (+9/-4) 4 files modified
bin/tarmac (+3/-1) tarmac/bin/__init__.py (+1/-1) tarmac/bin/commands.py (+3/-0) tarmac/bin/registry.py (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~james-w/tarmac/exit-status |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jonathan Lange (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2012-12-18.
Description of the change
Hi,
This allows the commands to set an exit status for the whole
tarmac script. We need it so that we can communicate some status
information to jenkins.
Thanks,
James
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+ if len(filter(lambda x: x is False, statuses)) > 0:
I don't know what's supposed to be in 'statuses', but this can definitely be simplified. If it's a sequence of booleans, then this is equivalent:
+ if False in statuses:
If it's a sequence of things which are to be interpreted as booleans, then this is equivalent:
+ if not all(statuses):
Other than that, it's all good. I'll update the MP and land it.
Oh, some test coverage would be nice.
jml