Code review comment for lp://staging/~james-w/pkgme/install-backends

On Fri, Jul 8, 2011 at 9:05 PM, James Westby <email address hidden> wrote:
>> Looks good.
>>
>> AIUI the code, this means that any files created in those directories will be
>> included in the sdist. Will any build artifacts be created underneath helpers
>> or backends as part of normal development?
>
> I can't think of anything except for maybe .pyc files or similar.
>
> There will also be things like editor backup files.
>

Hmm. I guess if the failure mode is just extra junk installed in
system directories, then it's not much to worry about.

>> Probably should also update README.txt along with this change.
>
> Is there something in particular you would change? I can't see anything
> there that would be broken by this change, and no special action should be
> needed to make use of it.
>

Oh, sorry, I should have been more specific.

I thought that the paragraph "If you want to override the default
location of the backends, ..." needed to be changed. Before this
patch, it was actually necessary to follow the instructions in order
to use pkgme (I think), and I had thought that now the paragraph could
be safely deleted.

However, I totally failed to parse the "If you want" bit, so I guess
it still makes sense to leave it there.

jml