pkgme

Merge lp://staging/~james-w/pkgme/install-backends into lp://staging/pkgme

  1. install-backends
  2. Merge into trunk
Proposed by James Westby
Status: Merged
Merged at revision: 57
Proposed branch: lp://staging/~james-w/pkgme/install-backends
Merge into: lp://staging/pkgme
Diff against target: 57 lines (+21/-1)
2 files modified
pkgme/backend.py (+1/-1)
setup.py (+20/-0)
To merge this branch: bzr merge lp://staging/~james-w/pkgme/install-backends
Reviewer Review Type Date Requested Status
Jonathan Lange Approve
pkgme committers Pending
Review via email: mp+66535@code.staging.launchpad.net

Description of the change

Hi,

This branch installs the backends in setup.py so that pkgme is actually
useful without having a source tree around and setting PKGME_BACKEND_PATHS.

It also has the script look relative to sys.prefix so that it works correctly
in a virtualenv.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

Looks good.

AIUI the code, this means that any files created in those directories will be included in the sdist. Will any build artifacts be created underneath helpers or backends as part of normal development?

Probably should also update README.txt along with this change.

cheers,
jml

review: Needs Fixing
Revision history for this message
James Westby (james-w) wrote :

> Looks good.
>
> AIUI the code, this means that any files created in those directories will be
> included in the sdist. Will any build artifacts be created underneath helpers
> or backends as part of normal development?

I can't think of anything except for maybe .pyc files or similar.

There will also be things like editor backup files.

> Probably should also update README.txt along with this change.

Is there something in particular you would change? I can't see anything
there that would be broken by this change, and no special action should be
needed to make use of it.

Thanks,

James

Revision history for this message
Jonathan Lange (jml) wrote :

On Fri, Jul 8, 2011 at 9:05 PM, James Westby <email address hidden> wrote:
>> Looks good.
>>
>> AIUI the code, this means that any files created in those directories will be
>> included in the sdist. Will any build artifacts be created underneath helpers
>> or backends as part of normal development?
>
> I can't think of anything except for maybe .pyc files or similar.
>
> There will also be things like editor backup files.
>

Hmm. I guess if the failure mode is just extra junk installed in
system directories, then it's not much to worry about.

>> Probably should also update README.txt along with this change.
>
> Is there something in particular you would change? I can't see anything
> there that would be broken by this change, and no special action should be
> needed to make use of it.
>

Oh, sorry, I should have been more specific.

I thought that the paragraph "If you want to override the default
location of the backends, ..." needed to be changed. Before this
patch, it was actually necessary to follow the instructions in order
to use pkgme (I think), and I had thought that now the paragraph could
be safely deleted.

However, I totally failed to parse the "If you want" bit, so I guess
it still makes sense to leave it there.

jml

Revision history for this message
Jonathan Lange (jml) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: