Juju Charms Collection
mysql package

Code review comment for lp://staging/~jacekn/charms/precise/mysql/n-e-m-relation

  1. Precise Pangolin (12.04)
  2. n-e-m-relation
  3. Merge into trunk
Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Hello Jacek,

Thanks for your submission. I have only a minor code observation ( commented on the diff ) , also the charm proof command is warning about config.yml keys (key, source, ) because they don't have default values, on which case default values should be : "".

Please review this few changes prior to get my +1.

review: Needs Resubmitting

« Back to merge proposal