Juju Charms Collection
mysql package

Merge lp://staging/~jacekn/charms/precise/mysql/n-e-m-relation into lp://staging/charms/mysql

Proposed by Jacek Nykis on 2014-05-08

Status:	Merged
Merged at revision:	125
Proposed branch:	lp://staging/~jacekn/charms/precise/mysql/n-e-m-relation
Merge into:	lp://staging/charms/mysql
Diff against target:	510 lines (+436/-2) 8 files modified config.yaml (+10/-0) hooks/charmhelpers/contrib/charmsupport/nrpe.py (+219/-0) hooks/charmhelpers/contrib/charmsupport/volumes.py (+156/-0) hooks/charmhelpers/fetch/__init__.py (+1/-1) hooks/config-changed (+4/-0) hooks/nrpe_relations.py (+42/-0) metadata.yaml (+3/-0) revision (+1/-1)
To merge this branch:	bzr merge lp://staging/~jacekn/charms/precise/mysql/n-e-m-relation
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Jorge Niedbalski (community)		Needs Resubmitting on 2014-06-20
charmers	2014-05-08	Pending
Review via email: mp+218785@code.staging.launchpad.net

Description of the change

Added support for nrpe-external-master relation.

Revision history for this message

Benjamin Saller (bcsaller) wrote on 2014-06-05:

+1 Thanks for updating the deps and fixing this.

While not directly your issues the charm still only passes proof with warnings and there are no tests, either for the main charm or these new additions. I'd encourage testing around some of the new code at a minimum.

Revision history for this message

Jorge Niedbalski (niedbalski) wrote on 2014-06-20:

Hello Jacek,

Thanks for your submission. I have only a minor code observation ( commented on the diff ) , also the charm proof command is warning about config.yml keys (key, source, ) because they don't have default values, on which case default values should be : "".

Please review this few changes prior to get my +1.

review: Needs Resubmitting