Code review comment for lp://staging/~ignacio-nin/percona-server/5.1-binary-out-of-source

Revision history for this message
Stewart Smith (stewart) wrote :

Alexey Kopytov <email address hidden> writes:
> Using "bzr export" means it will be impossible to use build-binary.sh
> when the source directory is not a bazaar branch, e.g. has been
> unpacked from a source tarball.
>
> I don't understand why we need that.

I'm of the idea that we should actually produce source tarball and then
build from it... this would ensure that our source tarball can be used
to build every binary we ship....

Perhaps build-binary.sh needs to check for .bzr and if so, call a (newly
created) build-source-tarball.sh which is basically just bzr export?

--
Stewart Smith

« Back to merge proposal