Percona Server moved to https://jira.percona.com/projects/PS

Merge lp://staging/~ignacio-nin/percona-server/5.1-binary-out-of-source into lp://staging/percona-server/5.1

  1. 5.1-binary-out-of-source
  2. Merge into 5.1
Proposed by Ignacio Nin
Status: Work in progress
Proposed branch: lp://staging/~ignacio-nin/percona-server/5.1-binary-out-of-source
Merge into: lp://staging/percona-server/5.1
Diff against target: 55 lines (+15/-7)
1 file modified
build/build-binary.sh (+15/-7)
To merge this branch: bzr merge lp://staging/~ignacio-nin/percona-server/5.1-binary-out-of-source
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Needs Fixing
Laurynas Biveinis (community) Approve
Review via email: mp+126528@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-09-24.

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote : Posted in a previous version of this proposal

Perhaps "make clean" is not required then, is it?

review: Needs Information
Revision history for this message
Ignacio Nin (ignacio-nin) wrote : Posted in a previous version of this proposal

make clean is not required indeed, as the branch has been just exported. Resubmitting without it.

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve
Reply
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Using "bzr export" means it will be impossible to use build-binary.sh when the source directory is not a bazaar branch, e.g. has been unpacked from a source tarball.

I don't understand why we need that.

Reply
Revision history for this message
Ignacio Nin (ignacio-nin) wrote :

> Using "bzr export" means it will be impossible to use build-binary.sh when the
> source directory is not a bazaar branch, e.g. has been unpacked from a source
> tarball.

Indeed, however these scripts convenience scripts meant for using with the full branch when we're building the packages (or a sample), not for the exported source. For an exported source a standard configure/make procedure should be used (and only the Percona-Server/ subdirectory).

Please notice that bzr(1) and a .bzr/ directory was already a requirement for the script since we use bzr revno for adding the revision number to the binary name.

Reply
Revision history for this message
Stewart Smith (stewart) wrote :

Alexey Kopytov <email address hidden> writes:
> Using "bzr export" means it will be impossible to use build-binary.sh
> when the source directory is not a bazaar branch, e.g. has been
> unpacked from a source tarball.
>
> I don't understand why we need that.

I'm of the idea that we should actually produce source tarball and then
build from it... this would ensure that our source tarball can be used
to build every binary we ship....

Perhaps build-binary.sh needs to check for .bzr and if so, call a (newly
created) build-source-tarball.sh which is basically just bzr export?

--
Stewart Smith

Reply
Revision history for this message
Alexey Kopytov (akopytov) wrote :

As discussed on IRC, we can fix build scripts to work when the source is
from a tarball by adding a REVNO file to the top-level directory in
tarballs. So the build scripts can use it, if it is available and resort
to bzr if it is not (or creating a tarball first, then using it to
build).

Reply
Revision history for this message
Alexey Kopytov (akopytov) :
review: Needs Fixing
Reply

Unmerged revisions

482. By Ignacio Nin

Build out of source (binary builder)

Instead of building in the source for the binary builder, export to
another directory and build there.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches