Code review comment for lp://staging/~headbangerkenny/ubuntuone-android-music/branch

Revision history for this message
Chad Miller (cmiller) wrote :

First, cheers on using File()s to create deep path, rather than succumbing to temptation to manually construct a string with slashes in it. I don't mind moving it to a standard location, but I wonder if it should be the standard "Music" directory instead. If you're going to move the location, you should handle old data and clean it up or move it, rather than abandoning it.

I don't think you mean a recurring Task in ShufflePlayBuffer.get() .

review: Needs Fixing

« Back to merge proposal