Merge lp://staging/~headbangerkenny/ubuntuone-android-music/branch into lp://staging/ubuntuone-android-music
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~headbangerkenny/ubuntuone-android-music/branch |
| Merge into: | lp://staging/ubuntuone-android-music |
| Diff against target: |
163 lines (+32/-8) 9 files modified
res/values/styles.xml (+2/-2) res/xml/appwidget_info.xml (+1/-1) src/net/sourceforge/subsonic/androidapp/activity/DownloadActivity.java (+8/-2) src/net/sourceforge/subsonic/androidapp/activity/MainActivity.java (+1/-1) src/net/sourceforge/subsonic/androidapp/service/CachedMusicService.java (+2/-0) src/net/sourceforge/subsonic/androidapp/service/DownloadService.java (+2/-0) src/net/sourceforge/subsonic/androidapp/service/DownloadServiceImpl.java (+2/-1) src/net/sourceforge/subsonic/androidapp/util/FileUtil.java (+2/-1) src/net/sourceforge/subsonic/androidapp/util/ShufflePlayBuffer.java (+12/-0) |
| To merge this branch: | bzr merge lp://staging/~headbangerkenny/ubuntuone-android-music/branch |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chad Miller (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Shuffle Songs improvements -- headbangerkenny
Description of the change
Basically improves the UX a little, so that new users get "Buffering" while the app is loading the shuffled playlist and automatically plays after "Shuffle Songs" is selected.
| Joe Simpson (headbangerkenny) wrote | # |
| Chad Miller (cmiller) wrote | # |
| Joe Simpson (headbangerkenny) wrote | # |
Unmerged revisions
- 530. By Joe Simpson
-
Removed that play(0); code that was requested. However, I have moved the cache folder from /sdcard/subsonic to /sdcard/
Android/ data/net. sourceforge. subsonic. u1m/music because Android says we should do that. Also, I noticed on my device that the ShuffleBuffer would randomly be empty, so when that happens on get() I tell it to grab more tracks, which works (I end up waiting up to 15 mins for this to refill on my device otherwise) - 529. By Joe Simpson
-
I have modified the Ubuntu One Music App so that when you tell it to Shuffle, it'll say it's buffering while the playlist is sorted out. Also it'll automatically play when pressing "Shuffle Songs" from the main screen.
- 528. By Chad Miller
-
Don't make non-ui events into Page Views in analytics.
- 527. By Chad Miller
-
When overriding Activities, be sure to call the superclass's same method. Android requires it.
- 526. By Michał Karnicki
-
Lower priority of media button receiver, unregister receiver when done.
- 525. By Chad Miller
-
Merge bad-index crash and trunk with analytics.
- 524. By Chad Miller
-
Don't dispatch automatically. We are going to use the network here, so dispatch only when we have the network active.
- 523. By Chad Miller
-
Revert bogus mistaken change to auth-return scheme.
- 522. By Chad Miller
-
Make analytics use more flag values, instead of magnitude values where appropriate.
Add analytics for cache miss and cache total-use. (Subtraction equals cache hit.)
Add analytics for free-space magnitude.
- 521. By Chad Miller
-
Make manual trackers dispatch events.
Make downloader start tracker correctly.
Add tracking to other Activities.
This is good, we definitely need feedback when waiting for the shuffle-queue to download. The shuffle buffer already starts playing, though.
MainActivity starts DownloadActivity, which checks the received intent for whether this is shuffle-play, and if it is, calls setShufflePlayE
On subsequent shuffle-play taps, should the music player do anything other than return the user to the place they were before? I need convincing it should do more.
I welcome the informational change for the user. With that only that change, I'd approve. Marking "Needs Fixing" to indicate that I so far don't want the other changes.