Merge lp://staging/~hatch/juju-gui/num-units-1253113 into lp://staging/juju-gui/experimental
Proposed by
Jeff Pihach
| Status: | Merged |
|---|---|
| Merged at revision: | 1219 |
| Proposed branch: | lp://staging/~hatch/juju-gui/num-units-1253113 |
| Merge into: | lp://staging/juju-gui/experimental |
| Diff against target: |
199 lines (+116/-7) 4 files modified
app/store/env/fakebackend.js (+5/-4) app/store/env/sandbox.js (+1/-1) test/test_fakebackend.js (+108/-0) test/test_sandbox_go.js (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~hatch/juju-gui/num-units-1253113 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Juju GUI Hackers | Pending | ||
|
Review via email:
|
|||
Description of the change
Fix: Removing units throws notification error
Removing units in the sandbox and in a real environment no longer
always throws an error.
To post a comment you must log in.
Revision history for this message
| Jeff Pihach (hatch) wrote | # |
Revision history for this message
| Madison Scott-Clary (makyo) wrote | # |
Revision history for this message
| Jeff Pihach (hatch) wrote | # |
Revision history for this message
| Jeff Pihach (hatch) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Reviewers: mp+197597_
Message:
Please take a look.
Description:
Fix: Removing units throws notification error
Removing units in the sandbox and in a real environment no longer
always throws an error.
To QA:
Sandbox:
Deploy a service with 10 units, change it to 1 unit, it should scale
down to 1.
Real environment:
Deploy a failtester service with 3 units in the GUI
after they are up scale it down to 1, they should scale down without
notifications.
https:/
(do not edit description out of merge proposal)
Please review this at https:/
Affected files (+118, -7 lines):
[revision details]
app/
app/
test/
test/