Code review comment for lp://staging/~hamo/ubuntu/precise/grub2/grub2.hi_res

Revision history for this message
Colin Watson (cjwatson) wrote :

Please could you redo this branch against lp:~ubuntu-core-dev/ubuntu/precise/grub2/precise and propose it for merging there? I don't use lp:ubuntu/precise-updates/grub2 for preparing uploads, and these two branches don't have a common ancestor so I can't merge this branch into the one that I do use.

The change itself looks reasonable. It probably breaks ABI between the GRUB core image and modules, but there's really not much to be done about that; we'll just need to watch out for the likelihood that some people will have problems on upgrade again because their core image isn't installed to the right place. I don't think it's the first time in the lifetime of precise that we've had to do this.

review: Needs Resubmitting

« Back to merge proposal