Merge lp://staging/~hamo/ubuntu/precise/grub2/grub2.hi_res into lp://staging/ubuntu/precise-updates/grub2
Proposed by
Yang Bai
| Status: | Rejected |
|---|---|
| Rejected by: | Colin Watson |
| Proposed branch: | lp://staging/~hamo/ubuntu/precise/grub2/grub2.hi_res |
| Merge into: | lp://staging/ubuntu/precise-updates/grub2 |
| Diff against target: |
1226 lines (+1206/-0) 3 files modified
debian/changelog (+6/-0) debian/patches/larger_terminal_size_restriction.patch (+1199/-0) debian/patches/series (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~hamo/ubuntu/precise/grub2/grub2.hi_res |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Colin Watson (community) | Needs Resubmitting | ||
|
Review via email:
|
|||
Description of the change
backport upstream commits to precise-updates 2b23074a0c08221
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Please could you redo this branch against lp:~ubuntu-core-dev/ubuntu/precise/grub2/precise and propose it for merging there? I don't use lp:ubuntu/precise-updates/grub2 for preparing uploads, and these two branches don't have a common ancestor so I can't merge this branch into the one that I do use.
The change itself looks reasonable. It probably breaks ABI between the GRUB core image and modules, but there's really not much to be done about that; we'll just need to watch out for the likelihood that some people will have problems on upgrade again because their core image isn't installed to the right place. I don't think it's the first time in the lifetime of precise that we've had to do this.