Code review comment for lp://staging/~haggai-eran/unity-greeter/rtl

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Hi Haggai,

I just had a play with this, thanks for keeping it up to date!

The main issues seem to be:
- The settings menu (cog) is on the right - it should be moved to the left to match Mika's sketch
- If you have mixed LTR and RTL entries the layout looks confused (I recommend picking one, i.e. if there is any RTL names then flip them all, or perhaps pick the majority).
- The login indicators (arrows beside the name) are still on the left

I'd also recommend replacing some explicit variable types (bool, double) with 'var' as this makes it easier to read.

review: Needs Fixing

« Back to merge proposal