Unity Greeter

Merge lp://staging/~haggai-eran/unity-greeter/rtl into lp://staging/~robert-ancell/unity-greeter/trunk

  1. rtl
  2. Merge into trunk
Proposed by Haggai Eran
Status: Work in progress
Proposed branch: lp://staging/~haggai-eran/unity-greeter/rtl
Merge into: lp://staging/~robert-ancell/unity-greeter/trunk
Diff against target: 159 lines (+64/-11)
1 file modified
src/user-list.vala (+64/-11)
To merge this branch: bzr merge lp://staging/~haggai-eran/unity-greeter/rtl
Reviewer Review Type Date Requested Status
Robert Ancell Needs Fixing
Review via email: mp+71665@code.staging.launchpad.net

Description of the change

Hi,

I've tried making unity-greeter translatable, and mirror the interface for right-to-left locales. I'm a bit new to vala, so I hope this is right.
I had to change the code that renders text to use Pango, as otherwise Hebrew characters wouldn't render. It seems to have changed how things look a little bit also for the English version.
I don't know if this can be avoided though.

I'll be glad if someone would have a look at this.

Regards,
Haggai

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Hi,

Sorry for the delay in getting back to you. I've just merged another branch that does the translations:
https://code.launchpad.net/~kelemeng/unity-greeter/bug831026/+merge/72457

But the RTL stuff sounds good too. Could you update this branch to have just the RTL changes? I've also asked the design team if they have an opinion on RTL behaviour.

Also, to contribute patches to Unity greeter you need to have signed the contributor agreement [1], can you please look over that?

[1] http://www.canonical.com/contributors

Thanks,
--Robert

Reply
Revision history for this message
Haggai Eran (haggai-eran) wrote :

Sure, I'll update my branch. About the contributor agreement, It will probably take me another two weeks to get my employer's approval, since everybody is on vacation right now. I'll tell you when I've signed it.

Reply
Revision history for this message
Robert Ancell (robert-ancell) wrote :

See Bug #834386 which I've opened so this issue can be better discussed.

Reply
lp://staging/~haggai-eran/unity-greeter/rtl updated
80. By Haggai Eran

Merged trunk changes.

Use pango font descriptor instead of ft2 font face.

81. By Haggai Eran

Fix username position with pango, and use absolute font size.

82. By Haggai Eran

Merged latest version. Use the new pango code.

83. By Haggai Eran

Handle entry ellipsizing according to the directionality.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Hi Haggai,

I just had a play with this, thanks for keeping it up to date!

The main issues seem to be:
- The settings menu (cog) is on the right - it should be moved to the left to match Mika's sketch
- If you have mixed LTR and RTL entries the layout looks confused (I recommend picking one, i.e. if there is any RTL names then flip them all, or perhaps pick the majority).
- The login indicators (arrows beside the name) are still on the left

I'd also recommend replacing some explicit variable types (bool, double) with 'var' as this makes it easier to read.

review: Needs Fixing
Reply
lp://staging/~haggai-eran/unity-greeter/rtl updated
84. By Haggai Eran

Merge trunk.

85. By Haggai Eran

Remove some variables types, and unneeded attr_size_new_absolute decleration.

Revision history for this message
Haggai Eran (haggai-eran) wrote :

Hi,

Perhaps we are not testing the greeter the same way, but for me the cog is on the left , and the login indicators are on the right. I've uploaded a screenshot to the bug here: https://bugs.launchpad.net/unity-greeter/+bug/834386/+attachment/2447007/+files/greeter-rtl.png

Are you testing the greeter with an RTL locale?

Reply
lp://staging/~haggai-eran/unity-greeter/rtl updated
86. By Haggai Eran

Merge trunk.

87. By Haggai Eran

Align entries according to the global direction, and not based on their individual directions.

Unmerged revisions

87. By Haggai Eran

Align entries according to the global direction, and not based on their individual directions.

86. By Haggai Eran

Merge trunk.

85. By Haggai Eran

Remove some variables types, and unneeded attr_size_new_absolute decleration.

84. By Haggai Eran

Merge trunk.

83. By Haggai Eran

Handle entry ellipsizing according to the directionality.

82. By Haggai Eran

Merged latest version. Use the new pango code.

81. By Haggai Eran

Fix username position with pango, and use absolute font size.

80. By Haggai Eran

Merged trunk changes.

Use pango font descriptor instead of ft2 font face.

79. By Haggai Eran

Move indicator menu to the left on right-to-left locales.

78. By Haggai Eran

Correct the alignment for right-to-left languages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches