Code review comment for lp://staging/~haggai-eran/unity-greeter/rtl

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Hi,

Sorry for the delay in getting back to you. I've just merged another branch that does the translations:
https://code.launchpad.net/~kelemeng/unity-greeter/bug831026/+merge/72457

But the RTL stuff sounds good too. Could you update this branch to have just the RTL changes? I've also asked the design team if they have an opinion on RTL behaviour.

Also, to contribute patches to Unity greeter you need to have signed the contributor agreement [1], can you please look over that?

[1] http://www.canonical.com/contributors

Thanks,
--Robert

« Back to merge proposal