Reviewers: mp+192269_code.launchpad.net,
Message: Please take a look.
Description: Enable running live tests against any EC2 region
There are two stages: * Making the test -amazon flag take a region name * Looking up real amis with simplestreams and using those in tests
Perhaps leaving the -amazon flag as an enabling bool, and setting a new flag just for selecting a region that defaults to us-east-1 would be better.
Both the simplestreams code and required test changes are pretty ugly, a bigger rewrite would help to clean up the tests.
https://code.launchpad.net/~gz/goamz/tests_amazon_region/+merge/192269
(do not edit description out of merge proposal)
Please review this at https://codereview.appspot.com/14930049/
Affected files (+304, -19 lines): A [revision details] M ec2/ec2i_test.go M ec2/ec2t_test.go A testutil/streams.go A testutil/streams_test.go M testutil/suite.go
« Back to merge proposal
Reviewers: mp+192269_ code.launchpad. net,
Message:
Please take a look.
Description:
Enable running live tests against any EC2 region
There are two stages:
* Making the test -amazon flag take a region name
* Looking up real amis with simplestreams and using those in tests
Perhaps leaving the -amazon flag as an enabling bool, and setting a new
flag just for selecting a region that defaults to us-east-1 would be
better.
Both the simplestreams code and required test changes are pretty ugly,
a bigger rewrite would help to clean up the tests.
https:/ /code.launchpad .net/~gz/ goamz/tests_ amazon_ region/ +merge/ 192269
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/14930049/
Affected files (+304, -19 lines): streams_ test.go
A [revision details]
M ec2/ec2i_test.go
M ec2/ec2t_test.go
A testutil/streams.go
A testutil/
M testutil/suite.go