goamz

Merge lp://staging/~gz/goamz/tests_amazon_region into lp://staging/goamz

  1. tests_amazon_region
  2. Merge into trunk
Proposed by Martin Packman
Status: Needs review
Proposed branch: lp://staging/~gz/goamz/tests_amazon_region
Merge into: lp://staging/goamz
Diff against target: 501 lines (+311/-29)
7 files modified
ec2/ec2_test.go (+7/-7)
ec2/ec2i_test.go (+17/-7)
ec2/ec2t_test.go (+21/-9)
ec2/ec2test/server.go (+1/-1)
testutil/streams.go (+91/-0)
testutil/streams_test.go (+150/-0)
testutil/suite.go (+24/-5)
To merge this branch: bzr merge lp://staging/~gz/goamz/tests_amazon_region
Reviewer Review Type Date Requested Status
goamz maintainers Pending
Review via email: mp+192269@code.staging.launchpad.net

Description of the change

Enable running live tests against any EC2 region

There are two stages:
 * Making the test -amazon flag take a region name
 * Looking up real amis with simplestreams and using those in tests

Perhaps leaving the -amazon flag as an enabling bool, and setting a new
flag just for selecting a region that defaults to us-east-1 would be
better.

Both the simplestreams code and required test changes are pretty ugly,
a bigger rewrite would help to clean up the tests.

https://codereview.appspot.com/14930049/

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Reviewers: mp+192269_code.launchpad.net,

Message:
Please take a look.

Description:
Enable running live tests against any EC2 region

There are two stages:
  * Making the test -amazon flag take a region name
  * Looking up real amis with simplestreams and using those in tests

Perhaps leaving the -amazon flag as an enabling bool, and setting a new
flag just for selecting a region that defaults to us-east-1 would be
better.

Both the simplestreams code and required test changes are pretty ugly,
a bigger rewrite would help to clean up the tests.

https://code.launchpad.net/~gz/goamz/tests_amazon_region/+merge/192269

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/14930049/

Affected files (+304, -19 lines):
   A [revision details]
   M ec2/ec2i_test.go
   M ec2/ec2t_test.go
   A testutil/streams.go
   A testutil/streams_test.go
   M testutil/suite.go

Reply
lp://staging/~gz/goamz/tests_amazon_region updated
46. By Martin Packman

go fmt

Revision history for this message
Martin Packman (gz) wrote :

Please take a look.

https://codereview.appspot.com/14930049/

Reply

Unmerged revisions

46. By Martin Packman

go fmt

45. By Martin Packman

Get real ami values for live tests from published simplestreams data

44. By Martin Packman

Change -amazon test flag to accept region value for testing against other regions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches