Code review comment for lp://staging/~gdukai/wms/fix-837952

Revision history for this message
Christophe CHAUVET (christophe-chauvet) wrote :

Hi

Thanks thanks for submiting as a branch

on second thought, we can change this line

if 'warehouse_id' not in values or not values['warehouse_id']:

by this one

if not values.get('warehouse_id', False):

As, if key not present is return False, and if present but return False it works

Comment ?

« Back to merge proposal