A SYLEAM Module - Warehouse Management System

Merge lp://staging/~gdukai/wms/fix-837952 into lp://staging/wms

  1. fix-837952
  2. Merge into 5.0
Proposed by Dukai Gábor
Status: Merged
Merged at revision: 241
Proposed branch: lp://staging/~gdukai/wms/fix-837952
Merge into: lp://staging/wms
Diff against target: 16 lines (+4/-2)
1 file modified
wms_sale/object/picking.py (+4/-2)
To merge this branch: bzr merge lp://staging/~gdukai/wms/fix-837952
Reviewer Review Type Date Requested Status
Christophe CHAUVET Approve
Review via email: mp+73758@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Christophe CHAUVET (christophe-chauvet) wrote :

Hi

Thanks thanks for submiting as a branch

on second thought, we can change this line

if 'warehouse_id' not in values or not values['warehouse_id']:

by this one

if not values.get('warehouse_id', False):

As, if key not present is return False, and if present but return False it works

Comment ?

lp://staging/~gdukai/wms/fix-837952 updated
242. By Dukai Gábor

last fix improved

Revision history for this message
Dukai Gábor (gdukai) wrote :

Sure, I've committed the changes.

Revision history for this message
Christophe CHAUVET (christophe-chauvet) wrote :

Thanks

Regards,

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches