Merge lp://staging/~gary/launchpad/small-cleanup into lp://staging/launchpad
Proposed by
Gary Poster
Status: | Merged |
---|---|
Approved by: | Gary Poster |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12862 |
Proposed branch: | lp://staging/~gary/launchpad/small-cleanup |
Merge into: | lp://staging/launchpad |
Diff against target: |
83 lines (+10/-17) 2 files modified
lib/lp/registry/javascript/structural-subscription.js (+7/-5) lib/lp/registry/javascript/tests/test_structural_subscription.js (+3/-12) |
To merge this branch: | bzr merge lp://staging/~gary/launchpad/small-cleanup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Approve | ||
Review via email:
|
Commit message
[r=danilo][no-qa] clean up some no-longer used cruft in the JS tests, and change a parent node to match the expected intent
Description of the change
This branch cleans up some no-longer used cruft in the JS tests, and changes a parent node to match the expected intent.
This is a follow-up from the testfix I just did for db-devel.
To post a comment you must log in.
Nice fix. I generally dislike the fact that node.appendChild() actually returns the appended node. The pattern itself reminds me of linked lists in C, thus I expect it to return the node itself.
If you agree, perhaps it's worth splitting up into two separate statements. If not, no problem, just land as-is :)