Code review comment for lp://staging/~gary/launchpad/small-cleanup

Revision history for this message
Данило Шеган (danilo) wrote :

Nice fix. I generally dislike the fact that node.appendChild() actually returns the appended node. The pattern itself reminds me of linked lists in C, thus I expect it to return the node itself.

If you agree, perhaps it's worth splitting up into two separate statements. If not, no problem, just land as-is :)

review: Approve

« Back to merge proposal