Code review comment for lp://staging/~gary/launchpad/launchpad-templates

Revision history for this message
Gary Poster (gary) wrote :

This changes the logintoken pages to use the new template layout. This was almost exclusively trivial mechanical changes.

Notes:

- Most of these token pages use context/@@main_template/master . The conversion guidelines suggest main_side or main_only for these, but locationless seems more appropriate. I checked with Guilherme and he agreed.

- I did not see how to verify the logintoken-index.pt page in the browser. It redirects to the correct page, so you do not actually see it. I could have done a wget or other tricks but I felt it was unnecessary.

- Someone had already migrated logintoken-mergepeople.pt.

Thank you!

Gary

« Back to merge proposal