Launchpad itself

Merge lp://staging/~gary/launchpad/launchpad-templates into lp://staging/launchpad

  1. launchpad-templates
  2. Merge into devel
Proposed by Gary Poster
Status: Merged
Approved by: Edwin Grubbs
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp://staging/~gary/launchpad/launchpad-templates
Merge into: lp://staging/launchpad
Diff against target: None lines
To merge this branch: bzr merge lp://staging/~gary/launchpad/launchpad-templates
Reviewer Review Type Date Requested Status
Edwin Grubbs (community) code Approve
Review via email: mp+11930@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

This changes the logintoken pages to use the new template layout. This was almost exclusively trivial mechanical changes.

Notes:

- Most of these token pages use context/@@main_template/master . The conversion guidelines suggest main_side or main_only for these, but locationless seems more appropriate. I checked with Guilherme and he agreed.

- I did not see how to verify the logintoken-index.pt page in the browser. It redirects to the correct page, so you do not actually see it. I could have done a wget or other tricks but I felt it was unnecessary.

- Someone had already migrated logintoken-mergepeople.pt.

Thank you!

Gary

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Hi Gary,

The template changes look good, but there are some other changes that are part of the 3.0 conversion. For each template that is updated to use the new layout, we want to get rid of the variable in lib/c/l/pagetitles.py, since the page title is now automatically generated to be the reverse breadcrumbs.

logintoken-validatesignonlygpg.pt and logintoken-index.pt have <h1> tags that should be eliminated by adding a "label" attribute on the view, and it will default to filling the heading slot with that.

-Edwin

review: Needs Fixing
Revision history for this message
Gary Poster (gary) wrote :

Thank you Edwin.

I think I made the necessary changes. They are pushed to the branch, and the incremental diff is here: http://pastebin.ubuntu.com/273020/ .

Gary

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Looks good.

merge-approved

-Edwin

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/templates/logintoken-claimprofile.pt'
2--- lib/canonical/launchpad/templates/logintoken-claimprofile.pt 2009-07-17 17:59:07 +0000
3+++ lib/canonical/launchpad/templates/logintoken-claimprofile.pt 2009-09-16 20:51:57 +0000
4@@ -3,10 +3,7 @@
5 xmlns:tal="http://xml.zope.org/namespaces/tal"
6 xmlns:metal="http://xml.zope.org/namespaces/metal"
7 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
8- xml:lang="en"
9- lang="en"
10- dir="ltr"
11- metal:use-macro="context/@@main_template/master"
12+ metal:use-macro="view/macro:page/locationless"
13 i18n:domain="launchpad"
14 >
15 <body>
16
17=== modified file 'lib/canonical/launchpad/templates/logintoken-claimteam.pt'
18--- lib/canonical/launchpad/templates/logintoken-claimteam.pt 2009-07-17 17:59:07 +0000
19+++ lib/canonical/launchpad/templates/logintoken-claimteam.pt 2009-09-16 20:51:57 +0000
20@@ -3,10 +3,7 @@
21 xmlns:tal="http://xml.zope.org/namespaces/tal"
22 xmlns:metal="http://xml.zope.org/namespaces/metal"
23 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
24- xml:lang="en"
25- lang="en"
26- dir="ltr"
27- metal:use-macro="context/@@main_template/master"
28+ metal:use-macro="view/macro:page/locationless"
29 i18n:domain="launchpad"
30 >
31 <body>
32
33=== modified file 'lib/canonical/launchpad/templates/logintoken-index.pt'
34--- lib/canonical/launchpad/templates/logintoken-index.pt 2009-07-17 17:59:07 +0000
35+++ lib/canonical/launchpad/templates/logintoken-index.pt 2009-09-16 20:51:57 +0000
36@@ -3,10 +3,7 @@
37 xmlns:tal="http://xml.zope.org/namespaces/tal"
38 xmlns:metal="http://xml.zope.org/namespaces/metal"
39 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
40- xml:lang="en"
41- lang="en"
42- dir="ltr"
43- metal:use-macro="context/@@main_template/master"
44+ metal:use-macro="view/macro:page/locationless"
45 i18n:domain="launchpad"
46 >
47
48@@ -18,7 +15,7 @@
49
50 <p>
51 You reached this page probably because you followed a link received by
52- email. That link was sent to confirm you have access to the email
53+ email. That link was sent to confirm you have access to the email
54 address it was sent to, but this confirmation was already concluded, so
55 you don't need to do anything else.
56 </p>
57
58=== modified file 'lib/canonical/launchpad/templates/logintoken-newaccount.pt'
59--- lib/canonical/launchpad/templates/logintoken-newaccount.pt 2009-07-17 17:59:07 +0000
60+++ lib/canonical/launchpad/templates/logintoken-newaccount.pt 2009-09-16 20:51:57 +0000
61@@ -3,10 +3,7 @@
62 xmlns:tal="http://xml.zope.org/namespaces/tal"
63 xmlns:metal="http://xml.zope.org/namespaces/metal"
64 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
65- xml:lang="en"
66- lang="en"
67- dir="ltr"
68- metal:use-macro="context/@@main_template/master"
69+ metal:use-macro="view/macro:page/locationless"
70 i18n:domain="launchpad"
71 >
72 <body>
73
74=== modified file 'lib/canonical/launchpad/templates/logintoken-resetpassword.pt'
75--- lib/canonical/launchpad/templates/logintoken-resetpassword.pt 2009-07-17 17:59:07 +0000
76+++ lib/canonical/launchpad/templates/logintoken-resetpassword.pt 2009-09-16 20:51:57 +0000
77@@ -3,10 +3,7 @@
78 xmlns:tal="http://xml.zope.org/namespaces/tal"
79 xmlns:metal="http://xml.zope.org/namespaces/metal"
80 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
81- xml:lang="en"
82- lang="en"
83- dir="ltr"
84- metal:use-macro="context/@@main_template/master"
85+ metal:use-macro="view/macro:page/locationless"
86 i18n:domain="launchpad"
87 >
88 <body>
89
90=== modified file 'lib/canonical/launchpad/templates/logintoken-validateemail.pt'
91--- lib/canonical/launchpad/templates/logintoken-validateemail.pt 2009-07-17 17:59:07 +0000
92+++ lib/canonical/launchpad/templates/logintoken-validateemail.pt 2009-09-16 20:51:57 +0000
93@@ -3,10 +3,7 @@
94 xmlns:tal="http://xml.zope.org/namespaces/tal"
95 xmlns:metal="http://xml.zope.org/namespaces/metal"
96 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
97- xml:lang="en"
98- lang="en"
99- dir="ltr"
100- metal:use-macro="context/@@main_template/master"
101+ metal:use-macro="view/macro:page/locationless"
102 i18n:domain="launchpad"
103 >
104 <body>
105
106=== modified file 'lib/canonical/launchpad/templates/logintoken-validategpg.pt'
107--- lib/canonical/launchpad/templates/logintoken-validategpg.pt 2009-07-17 17:59:07 +0000
108+++ lib/canonical/launchpad/templates/logintoken-validategpg.pt 2009-09-16 20:51:57 +0000
109@@ -3,10 +3,7 @@
110 xmlns:tal="http://xml.zope.org/namespaces/tal"
111 xmlns:metal="http://xml.zope.org/namespaces/metal"
112 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
113- xml:lang="en"
114- lang="en"
115- dir="ltr"
116- metal:use-macro="context/@@main_template/master"
117+ metal:use-macro="view/macro:page/locationless"
118 i18n:domain="launchpad"
119 >
120 <body>
121
122=== modified file 'lib/canonical/launchpad/templates/logintoken-validatesignonlygpg.pt'
123--- lib/canonical/launchpad/templates/logintoken-validatesignonlygpg.pt 2009-07-17 17:59:07 +0000
124+++ lib/canonical/launchpad/templates/logintoken-validatesignonlygpg.pt 2009-09-16 20:51:57 +0000
125@@ -3,10 +3,7 @@
126 xmlns:tal="http://xml.zope.org/namespaces/tal"
127 xmlns:metal="http://xml.zope.org/namespaces/metal"
128 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
129- xml:lang="en"
130- lang="en"
131- dir="ltr"
132- metal:use-macro="context/@@main_template/master"
133+ metal:use-macro="view/macro:page/locationless"
134 i18n:domain="launchpad"
135 >
136 <body>
137
138=== modified file 'lib/canonical/launchpad/templates/logintoken-validateteamemail.pt'
139--- lib/canonical/launchpad/templates/logintoken-validateteamemail.pt 2009-07-17 17:59:07 +0000
140+++ lib/canonical/launchpad/templates/logintoken-validateteamemail.pt 2009-09-16 20:51:57 +0000
141@@ -3,10 +3,7 @@
142 xmlns:tal="http://xml.zope.org/namespaces/tal"
143 xmlns:metal="http://xml.zope.org/namespaces/metal"
144 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
145- xml:lang="en"
146- lang="en"
147- dir="ltr"
148- metal:use-macro="context/@@main_template/master"
149+ metal:use-macro="view/macro:page/locationless"
150 i18n:domain="launchpad"
151 >
152 <body>