Merge lp://staging/~gary/launchpad/bug531071 into lp://staging/launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Данило Шеган | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 10897 | ||||
Proposed branch: | lp://staging/~gary/launchpad/bug531071 | ||||
Merge into: | lp://staging/launchpad | ||||
Diff against target: |
33 lines (+5/-4) 1 file modified
lib/lp/translations/browser/translationmessage.py (+5/-4) |
||||
To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug531071 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Approve | ||
Review via email:
|
Commit message
address the primary memory leak discovered for bug 531071.
Description of the change
This branch addresses the primary memory leak discovered for bug 531071.
Danilo said the following on IRC: "moving it out of the function declaration is fine, but please do not do any bigger changes (we have a big feature branch in progress and don't want to get too many conflicts) unless it's really critical (i.e. this doesn't help enough)"
In that context, I did the minimum necessary (though my editor cleaned up a single trailing whitespace; I hope that is not painful).
I did not attempt to write a test for the memory leak. I think it would have been possible, but given that this is being refactored soon, I didn't feel it merited the effort involved.
As described in the bug, there's another change to be made in Zope infrastructure, but I do not believe it is pressing once this change is made. I intend for this change to close the bug.
Thank you.
All good.