Code review comment for lp://staging/~gary/juju-quickstart/authtoken

Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+196982_code.launchpad.net,

Message:
Please take a look.

Description:
Add autologin support for quickstart

To qa, please do the following.

Story 1: quickstart works without autologin support for charm.

Simply run `.venv/bin/python juju-quickstart`. This will bring up the
existing charm, which does not have support for autologin. It should
work fine, with password.

Story 2: quickstart works with autologin when available.

Run `.venv/bin/python juju-quickstart --gui-charm-url
cs:~juju-gui/precise/juju-gui-134`.

This should bring up the GUI with autologin.

Thank you!

https://code.launchpad.net/~gary/juju-quickstart/authtoken/+merge/196982

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/34420043/

Affected files (+112, -28 lines):
   A [revision details]
   M quickstart/app.py
   M quickstart/juju.py
   M quickstart/manage.py
   M quickstart/tests/test_app.py
   M quickstart/tests/test_juju.py
   M quickstart/tests/test_manage.py

« Back to merge proposal